Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of unused onExceptionalCallback #7970

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Removal of unused onExceptionalCallback #7970

merged 2 commits into from
Oct 4, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Oct 4, 2023 •
edited
Loading

Pull Request Description

While working on #7683 it turned out that onExceptionCallback isn't really used anywhere. Removing.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • All code has been tested:
    • Unit tests continue to work

@JaroslavTulach JaroslavTulach self-assigned this Oct 4, 2023
@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 4, 2023
4e6
4e6 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect that

@JaroslavTulach JaroslavTulach merged commit aada58e into develop Oct 4, 2023
34 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/RemovalOfOnExceptionalCallback_7683 branch October 4, 2023 14:15
@JaroslavTulach JaroslavTulach mentioned this pull request Oct 4, 2023
Merged
3 tasks
@enso-bot enso-bot bot mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@4e6 4e6 4e6 approved these changes

@Akirathan Akirathan Akirathan approved these changes

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JaroslavTulach @hubertp @4e6 @Akirathan