Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Table.expand_to_rows to allow flattening vector and array values in table #8029

Closed
wants to merge 39 commits into from
Closed

Add Table.expand_to_rows to allow flattening vector and array values in table #8029

wants to merge 39 commits into from

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Oct 11, 2023 •
edited

Important Notes

Also includes a fix for a builder retyping bug.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

GregoryTravis and others added 30 commits October 6, 2023 14:58
@GregoryTravis
one test
76c4f01
@GregoryTravis
single values
6cc1ee0
@GregoryTravis
singles with field lists
c02c06d
@GregoryTravis
json
b0498f4
@GregoryTravis
e+m
97fa5c2
@GregoryTravis
json
7b7d886
@GregoryTravis
array
bd13286
@GregoryTravis
expand_column
248f7b3
@GregoryTravis
prefix
f77eb4d
@GregoryTravis
error on db
e9afa39
@GregoryTravis
Merge branch 'develop' into wip/gmt/7958-from-objects-tests
c8a2825
@GregoryTravis
db tests pass
efe7926
@GregoryTravis
cleanup
b288c88
@GregoryTravis
group name
d26dd19
@GregoryTravis
tests
66a0c1a
@GregoryTravis
mixed
199ab21
@GregoryTravis
wrote
e02d44a
@GregoryTravis
works with inferred builder
5911986
@GregoryTravis
review
10d48eb
@GregoryTravis @radeusgd
Update test/Table_Tests/src/Common_Table_Operations/Conversion_Spec.enso
aedb4ad 
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
@GregoryTravis @radeusgd
Update test/Table_Tests/src/In_Memory/Table_Conversion_Spec.enso
6e639d3 
Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
@GregoryTravis
ignored
306695d
@GregoryTravis
review
b9f2d72
@GregoryTravis
Merge branch 'wip/gmt/7958-from-objects-tests' into wip/gmt/7959-etr
7637c00
@GregoryTravis
remove test
ac1fbdd
@GregoryTravis
Merge branch 'wip/gmt/7958-from-objects-tests' into wip/gmt/7959-etr
058cdd7
@GregoryTravis
hack
afa7271
@GregoryTravis
improved fix
e8c87f7
@GregoryTravis
merge
757ff7c
@GregoryTravis
correct fix with test
8f88488
@GregoryTravis GregoryTravis linked an issue Oct 11, 2023 that may be closed by this pull request
Add Table.expand_to_rows to allow flattening vector and array values in table. #7959
Closed
@GregoryTravis GregoryTravis marked this pull request as ready for review October 11, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Table.expand_to_rows to allow flattening vector and array values in table.
1 participant
@GregoryTravis