Backend self sampling #8309
Merged
Backend self sampling #8309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
hubertp
approved these changes
Nov 17, 2023
engine/language-server/src/main/scala/org/enso/languageserver/profiling/ProfilingManager.scala
Outdated
Show resolved
Hide resolved
Akirathan
approved these changes
Nov 17, 2023
| import java.util.concurrent.Executor; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| public interface MethodsSampler { |
There was a problem hiding this comment.
sealed interface is probably what you want with the two implementations being permits listed.
| public void start() {} | ||
|
|
||
| @Override | ||
| public void stop() {} |
There was a problem hiding this comment.
scheduleStop could be no-op either.
| * Gathers application performance statistics that can be visualised in Java VisualVM, and writes it | ||
| * to the provided output. | ||
| */ | ||
| public final class OutputStreamSampler implements MethodsSampler { |
There was a problem hiding this comment.
To keep the API's conceptual surface smaller, I'd suggest to make these implementations package private and only expose MethodsSampler.
| } | ||
|
|
||
| public static OutputStreamSampler ofFile(File file) throws FileNotFoundException { | ||
| return new OutputStreamSampler(new FileOutputStream(file)); |
There was a problem hiding this comment.
This means the stream is open during the whole sampling rather than being opened and close just for the time of stoping and writing the data down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #8248
Changelog:
profiling/startrequest starts the sampler and starts collecting runtime events to the log fileprofiling/stoprequest stop the sampler and write the profiling data to the$ENSO_DATA_DIR/profilingdirectoryImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.