On-deman backend heap and thread dump #8320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
JaroslavTulach
approved these changes
Nov 18, 2023
lib/scala/profiling-utils/src/main/java/org/enso/profiling/snapshot/HeapDumpGenerator.java
Outdated
Show resolved
Hide resolved
| @@ -14,4 +14,10 @@ object ProfilingProtocol { | |||
| /** A response to request to stop the profiling. */ | |||
| case object ProfilingStopResponse | |||
|
|
|||
| /** A request to create a memory snapshot. */ | |||
| case object ProfilingSnapshotRequest | |||
There was a problem hiding this comment.
Is it really profiling? Isn't it memory dump or "telemetry snapshot"?
hubertp
approved these changes
Nov 20, 2023
lib/scala/profiling-utils/src/main/java/org/enso/profiling/snapshot/HeapDumpGenerator.java
Outdated
Show resolved
Hide resolved
| @Test | ||
| public void generateHeapDump() throws IOException { | ||
| String heapDumpFileName = | ||
| getClass().getSimpleName() + "-" + System.currentTimeMillis() + ".hprof"; |
There was a problem hiding this comment.
Might be easier to locate if this has a human-readable time format.
There was a problem hiding this comment.
It is supposed to be removed after the test anyway. The actual heap dump file created by the language server will be in a human-readable format.
mergify
bot
deleted the
wip/db/8249-on-deman-backend-heap-and-thread-dump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #8249
Changelog:
profiling/snapshotrequest that takes a heap dump of the language server and puts it in theENSO_DATA_DIRECTORY/profilingdirecotryImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.