Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always create events log when profiling #8337

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Always create events log when profiling #8337

merged 2 commits into from
Nov 20, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Nov 20, 2023

Pull Request Description

Changelog:

  • update: always create an event log next to the profiling file when the engine is started with the --profiling-path flag
  • remove: --profiling-events-log-path flag

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 20, 2023
@4e6 4e6 self-assigned this Nov 20, 2023
JaroslavTulach
JaroslavTulach approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to drop the "events log path" option and derive its value from location of .npss file.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Nov 20, 2023
@mergify mergify bot merged commit 53d1f72 into develop Nov 20, 2023
30 of 33 checks passed
@mergify mergify bot deleted the wip/db/unify-profiling-flags branch November 20, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@4e6 4e6

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@4e6 @hubertp @JaroslavTulach