-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply ICONs #8360
Apply ICONs #8360
Conversation
Add first pass of some ICONs.
@jdunkerley are the names for the icons taken from an existing figma design somewhere? |
also, i'm aware it's well out of scope of this, but thoughts on having hardcoded icons for certain method names? or should methods without icons perhaps fall back to the Enso icon as per the website2 design? |
Is there some place where we can see what each of the icons looks like? |
## GROUP Metadata | ||
Gets elements matching a given tag name. | ||
## Gets elements matching a given tag name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the +- guidelines for when a method gets assigned to a group VS it has no group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very roughly, the most common use functions.
The CB needs a little more design work which we will start on soon.
I imagine we will end up with ADVANCED
being used as the second step filter.
@somebody1234 the names are from the old IDE. I will be putting a PR up to make them work in the new IDE. |
Yes @radeusgd Old IDE run |
Pull Request Description
The linter tool has been updated to support rewriting the ICON as well.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.