Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ICONs #8360

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Apply ICONs #8360

merged 3 commits into from
Nov 22, 2023

Conversation

jdunkerley
Copy link
Member

Pull Request Description

  • Amend a couple of missed groups.
  • Add the first pass of some ICONs.

The linter tool has been updated to support rewriting the ICON as well.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Add first pass of some ICONs.
@somebody1234
Copy link
Collaborator

@jdunkerley are the names for the icons taken from an existing figma design somewhere?
or do they correspond to icons in the figma design, but with slightly different names?
(or perhaps are the icons supposed to be created based on the names?)

@somebody1234
Copy link
Collaborator

also, i'm aware it's well out of scope of this, but thoughts on having hardcoded icons for certain method names? or should methods without icons perhaps fall back to the Enso icon as per the website2 design?

@radeusgd
Copy link
Member

Is there some place where we can see what each of the icons looks like?

## GROUP Metadata
Gets elements matching a given tag name.
## Gets elements matching a given tag name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the +- guidelines for when a method gets assigned to a group VS it has no group?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very roughly, the most common use functions.
The CB needs a little more design work which we will start on soon.
I imagine we will end up with ADVANCED being used as the second step filter.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 22, 2023
@jdunkerley
Copy link
Member Author

@jdunkerley are the names for the icons taken from an existing figma design somewhere? or do they correspond to icons in the figma design, but with slightly different names? (or perhaps are the icons supposed to be created based on the names?)

@somebody1234 the names are from the old IDE. I will be putting a PR up to make them work in the new IDE.

@jdunkerley
Copy link
Member Author

Is there some place where we can see what each of the icons looks like?

Yes @radeusgd

Old IDE run Enso.exe --startup.entry=icons
New IDE run npm run story:dev and then go to the hosted page and then All SVG Icons.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Nov 22, 2023
@mergify mergify bot merged commit f60836d into develop Nov 22, 2023
30 of 33 checks passed
@mergify mergify bot deleted the wip/jd/icons branch November 22, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants