Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ICON section work consistently between old and new GUI. #8369

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Nov 22, 2023

Pull Request Description

  • Handle name mismatch in icons between old and new IDE.
  • Set the default icon for a few types.
  • If can't find and icon use the Enso logo.

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Set the default icon for a few types.
If can't find and icon use the Enso logo.
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 22, 2023
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Nov 22, 2023
@mergify mergify bot merged commit ed9e71c into develop Nov 23, 2023
29 of 33 checks passed
@mergify mergify bot deleted the wip/jd/gui2-icons branch November 23, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants