Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for test/Benchmarks #8391

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Filter for test/Benchmarks #8391

merged 2 commits into from
Nov 27, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Nov 26, 2023

Pull Request Description

With herein proposed change one can pass an optional filter to enso --run test/Benchmarks to execute only groups and specs that contain given string in its name.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary - done in 59901e4
  • All code follows the
    style guides.
  • All code has been tested:
    • Code was manually tested

@JaroslavTulach
Copy link
Member Author

enso$ enso --run test/Benchmarks/ Computing_Proxy
Found 1 benchmark suites, containing 2 specs in total.
The minimal estimated run time based on configurations is 24s.
Found 2 cases to execute (ETA 24s)
Benchmark 'Vector_Array_Proxy.Sum_Computing_Proxy' finished in 12207.738 ms
Benchmark 'Vector_Array_Proxy.Sum_Vector_relying_on_Computing_Proxy' finished in 12028.108 ms

Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation in docs/infrastructure/benchmarks.md?

Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quality of life improvement. Please add docs either to benchmarks.md or attach a doc comment to the main method. It is not entirely clear how the filter parameter should work.

@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Nov 27, 2023
@mergify mergify bot merged commit c6eb61a into develop Nov 27, 2023
30 of 31 checks passed
@mergify mergify bot deleted the wip/jtulach/BenchmarkFilter branch November 27, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants