Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed lookup_and_replace to merge and renamed Table.replace to text… #8564

Merged
merged 15 commits into from
Dec 20, 2023
Merged

Renamed lookup_and_replace to merge and renamed Table.replace to text… #8564

merged 15 commits into from
Dec 20, 2023

Conversation

Cassandra-Clark
Copy link
Contributor

…_replace

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code has been tested:
    • Unit tests have been written where possible.

@Cassandra-Clark Cassandra-Clark linked an issue Dec 15, 2023 that may be closed by this pull request
Review design of lookup_and_replace and replace. #8322
Closed
radeusgd
radeusgd requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Database.Table functions being renamed, but the in-memory Table seems to be left unmodified? We need to make sure all are consistent.

CHANGELOG.md Outdated Show resolved Hide resolved
jdunkerley
jdunkerley reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore database merge.

jdunkerley
jdunkerley approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just rename Lookup_Spec.enso to Merge_Spec.enso please.
Then once merged please fix all the project templates which have lookup_and_replace.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 20, 2023
@mergify mergify bot merged commit 232077f into develop Dec 20, 2023
31 checks passed
@mergify mergify bot deleted the 8322-lookup-and-replace-design branch December 20, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review design of lookup_and_replace and replace.
4 participants
@Cassandra-Clark @radeusgd @jdunkerley @GregoryTravis