Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text_length to column for in-memory and database #8606

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Add text_length to column for in-memory and database #8606

merged 6 commits into from
Dec 21, 2023

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Dec 20, 2023

Pull Request Description

Closes #8521
Adds text_length to Column

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [ x] The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [ x] Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

radeusgd
radeusgd approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all great!

A few minor comments/suggestions

distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Column.enso Outdated Show resolved Hide resolved
test/Table_Tests/src/Common_Table_Operations/Column_Operations_Spec.enso Outdated Show resolved Hide resolved
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 21, 2023
@AdRiley AdRiley removed the CI: Ready to merge This PR is eligible for automatic merge label Dec 21, 2023
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Dec 21, 2023
@mergify mergify bot merged commit cfe0cbe into develop Dec 21, 2023
31 checks passed
@mergify mergify bot deleted the wip/adr/add-text_length-column-function branch December 21, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Text Length to the Column APIs
5 participants
@AdRiley @CLAassistant @radeusgd @jdunkerley @GregoryTravis