Updating Espresso support & docs to match GraalVM for JDK21 #8641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
Akirathan
reviewed
Dec 28, 2023
engine/runner/src/main/scala/org/enso/runner/ContextFactory.scala
Outdated
Show resolved
Hide resolved
JaroslavTulach
force-pushed
the
wip/jtulach/Espresso21
branch
2 times, most recently
from
f603a33
to
8b89ec8
Compare
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
commented
Dec 29, 2023
build/build/src/engine/context.rs
Outdated
| @@ -523,24 +523,24 @@ impl RunContext { | |||
| } | |||
|
|
|||
|
|
|||
| // if build_native_runner { | |||
There was a problem hiding this comment.
This code has been introduced by
Looking at the commits in the PR it looks like @mwu-tow tried to add the test, but failed. Can we enable such test now? Do you know how to fix the failure, @mwu-tow?
Can we also expand the test to run twice and once use ENSO_JAVA=espresso, @mwu-tow?
JaroslavTulach
changed the title
JaroslavTulach
added
the
CI: Clean build required
hubertp
approved these changes
Jan 3, 2024
JaroslavTulach
force-pushed
the
wip/jtulach/Espresso21
branch
from
b188751
to
67eb767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Updating instructions to use Enso with Espresso.
Important Notes
NI
runnercan be built, but doesn't initialize Espresso properly.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,