Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove org.bouncycastle dependency #8664

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Jan 3, 2024

Fixes #8362

Pull Request Description

Remove the org.bouncycastle dependency from org.enso.runtime module.

Important Notes

  • Digest computation is done with JDK classes instead of org.bouncycastle.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • Manually run engine benchmarks and ensure that the performance of startup benchmarks is back to its previous value before Add graalpy packages to the component directory #8351
  • The documentation has been updated, if necessary.
  • All code has been tested:
    • Unit tests have been written where possible.

@Akirathan Akirathan self-assigned this Jan 3, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 3, 2024
@Akirathan Akirathan marked this pull request as ready for review January 3, 2024 18:07
@Akirathan
Copy link
Member Author

Akirathan commented Jan 3, 2024

Engine benchmarks scheduled at https://github.com/enso-org/enso/actions/runs/7400828290

stdlib benchmarks scheduled at https://github.com/enso-org/enso/actions/runs/7400834645

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Jan 4, 2024

stdlib benchmarks scheduled at https://github.com/enso-org/enso/actions/runs/7400834645

There is a failure related to bouncycastle:

running (fork) org.enso.benchmarks.libs.LibBenchRunner 
Error occurred during initialization of boot layer
java.lang.LayerInstantiationException: Package org.bouncycastle.tsp.ers in both module 
  org.enso.runtime and module org.bouncycastle.pkix
 (std-benchmarks / Bench / run) Nonzero exit code returned from runner: 1
GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan
Copy link
Member Author

There is a failure related to bouncycastle:

This is because of the incremental builds. Let me clean all the runners and reschedule that job again.

@Akirathan
Copy link
Member Author

Akirathan commented Jan 4, 2024

Another attempt of std-lib benchmarks started at https://github.com/enso-org/enso/actions/runs/7408255173

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan
Copy link
Member Author

Another attempt of std-lib benchmarks started at enso-org/enso/actions/runs/7408255173

GitHub**Benchmark Standard Libraries · enso-org/enso@b85d5e5**Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

Looking at the bench comparison at generated_site.zip, removing org.bouncycastle dependency from org.enso.runtime does not help in org_enso_benchmarks_generated_Startup_empty_startup.

Engine benchmarks are the same.

@Akirathan
Copy link
Member Author

Although removing org.bouncycastle dependency did not help with the benchmarks, it is still valuable. Let's merge this PR now, and continue with the startup slowdown investigation in another PR.

@Akirathan Akirathan merged commit 428e83d into develop Jan 4, 2024
36 of 37 checks passed
@Akirathan Akirathan deleted the wip/akirathan/8553-graalpy-startup-slowdown branch January 4, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove compile time dependency on bouncycastle
6 participants