Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change project module name to Upper_Snake_Case #8697

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jan 6, 2024

Pull Request Description

close #8649

Do not mangle the project module name. Only strip the unsupported characters and make it a valid Enso module identifier.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 6, 2024
@4e6 4e6 self-assigned this Jan 6, 2024
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Jan 8, 2024
@mergify mergify bot merged commit 5e0a733 into develop Jan 8, 2024
34 of 36 checks passed
@mergify mergify bot deleted the wip/db/8649-fix-the-name-of-folders-when-renaming branch January 8, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the name of folders when renaming locally for cases like AoC_1
3 participants