Remove set_user_info from URI

[radeusgd]

Pull Request Description

I have added this in #8591, but I have realised it may not be a good idea to have it, so I am removing that particular change.

Rationale for the changes

Reading RFC 3986 we can see that setting a password through user-info is deprecated, because it is deemed unsafe.

Moreover, basic testing suggests that our HTTP client did not in fact send this user info anyway (I'm not 100% sure of that, I'm however quite sure that it was not possible to read this data back in our HTTP server using the available APIs, after some digging).

It seems that the typical thing to do with user info specified in URI is to convert it into the Authorization: Basic HTTP header. At least that is what CURL does:

$ curl -v http://a:b@localhost:8080/get
*   Trying [::1]:8080...
* Connected to localhost (::1) port 8080
* Server auth using Basic with user 'a'
> GET /get HTTP/1.1
> Host: localhost:8080
> Authorization: Basic YTpi
> User-Agent: curl/8.4.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Thu, 11 Jan 2024 13:39:28 GMT
< Content-type: application/json
< Content-length: 191
<
{
  "headers": {
    "Accept": "*/*",
    "User-Agent": "curl/8.4.0",
    "Authorization": "Basic YTpi"
  },
  "origin": "0:0:0:0:0:0:0:1",
  "path": "/get",
  "method": "GET",
  "args": {}
}* Connection #0 to host localhost left intact

So, there is no 'native' support for user info in the URI. What we could do is automatically translate it into the Authorization: Basic header, like CURL does - but I'm not sure that this would be the right call. Instead, I think the user should refrain from using the user info at all for authorization, and just use our Header.authorization_basic instead.

Note that this does not prevent users from typing in user info directly, e.g. URI.from "http://user@pass:example.com/" will still be parsed and include the user info in the URI, handling it with the default behaviour (i.e. it will unfortunately be ignored later).

The only API change is that we remove set_user_info helper, which was encouraging users to use this deprecated feature.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[jdunkerley]

Minor fix