Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secrets in Header.authorization_* #8761

Merged
merged 13 commits into from
Jan 18, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 15, 2024
@radeusgd radeusgd self-assigned this Jan 15, 2024
@radeusgd radeusgd changed the title PoC for derived secret values and secrets in headers Allow values and secrets in headers Jan 15, 2024
@radeusgd radeusgd changed the title Allow values and secrets in headers Allow secrets in Header.authorization_* Jan 15, 2024
@radeusgd radeusgd force-pushed the wip/radeusgd/deprecate-user-info branch from b62440e to f238417 Compare January 15, 2024 16:26
@radeusgd radeusgd force-pushed the wip/radeusgd/8739-secrets-in-auth-headers branch from d40a5bd to a9667f9 Compare January 15, 2024 16:31
Base automatically changed from wip/radeusgd/deprecate-user-info to develop January 15, 2024 17:35
@radeusgd radeusgd force-pushed the wip/radeusgd/8739-secrets-in-auth-headers branch from a9667f9 to 604ec34 Compare January 15, 2024 23:39
@radeusgd radeusgd force-pushed the wip/radeusgd/8739-secrets-in-auth-headers branch from 604ec34 to 4cfdf65 Compare January 15, 2024 23:44
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Don't think any way to avoid the parallel Java and Enso structures but doubt a big issue as don't imagine a massive more structure needed.

@radeusgd radeusgd force-pushed the wip/radeusgd/8739-secrets-in-auth-headers branch from 735e5c0 to 3323131 Compare January 16, 2024 13:27
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jan 16, 2024
@radeusgd radeusgd added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 16, 2024
@mergify mergify bot merged commit 14be36c into develop Jan 18, 2024
26 of 27 checks passed
@mergify mergify bot deleted the wip/radeusgd/8739-secrets-in-auth-headers branch January 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow secrets in Header.authorization_basic and Header.authorization_bearer
3 participants