Small boolean widget tweaks #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
CI: No changelog needed
farmaazon
requested review from
Frizi,
MichaelMauderer,
vitvakatu and
kazcw
as code owners
vitvakatu
reviewed
Feb 8, 2024
| return entry.reexportedIn | ||
| ? unqualifiedImport(entry.reexportedIn) | ||
| : entry.memberOf | ||
| ? unqualifiedImport(entry.memberOf) |
There was a problem hiding this comment.
I’m not sure this particular line is correct. IIRC, memberOf would be the module in which the type is defined, so from Module import Constructor will probably be invalid.
There was a problem hiding this comment.
No, memberOf is type on which it's defined. The module where the entity is defined is actually definedIn field.
Frizi
reviewed
Feb 8, 2024
| @@ -136,11 +139,21 @@ watch(selectedIndex, (_index) => { | |||
| </script> | |||
|
|
|||
| <script lang="ts"> | |||
| function hasBooleanTagValues(parameter: SuggestionEntryArgument): boolean { | |||
| if (parameter.tagValues == null) return false | |||
There was a problem hiding this comment.
This whole function could be made simpler by creating some sorts of arrayEquals utility and using it here.
| export const widgetDefinition = defineWidget(WidgetInput.isAstOrPlaceholder, { | ||
| priority: 50, | ||
| score: (props) => { | ||
| if (props.input.dynamicConfig?.kind === 'Single_Choice') return Score.Perfect | ||
| if (props.input[ArgumentInfoKey]?.info?.tagValues != null) return Score.Perfect | ||
| // Boolean arguments also have tag values, but the checkbox widget should handle them. | ||
| if (props.input[ArgumentInfoKey]?.info?.tagValues != null && !hasBooleanTagValues) |
There was a problem hiding this comment.
Here the hasBooleanTagValues function is not actually called.
There was a problem hiding this comment.
Can we enable some lint for checking it?
…/boolean-widget-tweaks
vitvakatu
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #8962
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.