Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ICON tags and a few new Icons. #8996

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Add some ICON tags and a few new Icons. #8996

merged 6 commits into from
Feb 8, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Feb 7, 2024

Pull Request Description

  • Apply @Cassandra-Clark's ICON tags to the library code.

  • Fix bug with Table viz not showing row count in dropdown list. Doesn't fix defect with dropdown not changing data.
    image

  • Added missing icons.
    image
    image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 7, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 8, 2024
@mergify mergify bot merged commit 93f2a44 into develop Feb 8, 2024
26 of 28 checks passed
@mergify mergify bot deleted the wip/jd/icons branch February 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants