CI: Tweaks for backend tests #9001
Conversation
| /// Get paths of directories containing standard library test project. | ||
| pub fn discover_standard_library_tests(repo_root: &generated::RepoRoot) -> Result<Vec<PathBuf>> { | ||
| // The glob pattern will discover paths like "H:\NBO\enso\test\AWS_Tests\package.yaml". | ||
| let glob_pattern = "**/*_Tests/package.yaml"; |
There was a problem hiding this comment.
| let glob_pattern = "**/*_Tests/package.yaml"; | |
| let glob_pattern = "test/*_Tests/package.yaml"; |
What about the above?
I'm not sure if we need to or even want to search in other directories.
There was a problem hiding this comment.
There are plans to move tests to be next to each library being tested (i.e. something like test folder next to src of each Enso library), so this may need an update then as well.
There was a problem hiding this comment.
What about the above?
I'm not sure if we need to or even want to search in other directories.
We attach the glob pattern to the repo_root.test which already paths to the test directory.
There was a problem hiding this comment.
There are plans to move tests to be next to each library being tested (i.e. something like
testfolder next tosrcof each Enso library), so this may need an update then as well.
Yes. This should not be a problem.
There was a problem hiding this comment.
What about the above?
I'm not sure if we need to or even want to search in other directories.We attach the glob pattern to the
repo_root.testwhich already paths to thetestdirectory.
In that case is the ** even needed?
Unless I'm wrong in this context, usually ** in a glob means multi-level directory traversal and I don't see why that would be needed - in our case we don't need nesting, all tests should be the immediate children of the test dir and looking 'deeper' seems like asking for trouble (if some test project contains an inner project for some reason).
That is a very minor nitpick though, as currently either way works 100% fine and we can always tweak it if needed. So feel free to ignore this suggestion.
…t-tweaks # Conflicts: # test/Meta_Test_Suite_Tests/data/asserts_outside_of_tests/Main.enso # test/Meta_Test_Suite_Tests/data/fail_report/Main.enso # test/Meta_Test_Suite_Tests/data/with_clue_1/Main.enso # test/Meta_Test_Suite_Tests/data/with_clue_2/Main.enso # test/Meta_Test_Suite_Tests/src/Main.enso
mwu-tow
added
-ci
-build-script
mwu-tow
requested review from
jdunkerley,
GregoryTravis and
AdRiley
as code owners
|
I added the follow-up ticket: #9018 |
Pull Request Description
Important Notes
The meta test suite tests are removed following the discussion with @radeusgd. In short, these were failing anyway and were supposed to be rewritten (probably using a different technology, like JUnit). The current code will be a useful reference but it doesn't have to be kept on a repository head. The relevant information and references shall be added to the task.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.