Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wrapped_error and make it private #9030

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Feb 12, 2024

Pull Request Description

Rename wrapped_error to DB_wrapped_error and make it private to avoid name clashes as part of #8981

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 12, 2024
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 12, 2024
@mergify mergify bot merged commit 6739426 into develop Feb 12, 2024
26 of 27 checks passed
@mergify mergify bot deleted the wip/adr/make-db-wrapped-error-private branch February 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants