Synchronize suggestions loading after the reconnect #9043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
JaroslavTulach
approved these changes
Feb 13, 2024
hubertp
reviewed
Feb 13, 2024
| @@ -33,6 +32,7 @@ public Future<BoxedUnit> executeAsynchronously(RuntimeContext ctx, ExecutionCont | |||
| TruffleLogger logger = ctx.executionService().getLogger(); | |||
| long writeCompilationLockTimestamp = ctx.locking().acquireWriteCompilationLock(); | |||
| try { | |||
| ctx.jobControlPlane().stopBackgroundJobs(); | |||
There was a problem hiding this comment.
I find this confusing - we stop all background jobs only to abort some of them?
There was a problem hiding this comment.
It may look like an overkill. But here we stop running new background jobs for a brief moment to ensure that the deserialization jobs will not be executed before we clean the suggestions database. After the database is cleaned, we re-start the background jobs processing.
hubertp
approved these changes
Feb 13, 2024
4e6
added a commit
that referenced
this pull request
Feb 22, 2024
related #8689 Fixes a race between the language server SQL updating logic and the engine `DeserializeLibrarySuggestionsJob`s when the library suggestions may start loading before the database is properly cleaned up after the reconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
related #8689
Fixes a race between the language server SQL updating logic and the engine
DeserializeLibrarySuggestionsJobs when the library suggestions may start loading before the database is properly cleaned up after the reconnect.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.