-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize UUID for non-library modules #9057
Conversation
Missing ID's in IR meant that instrumentation wouldn't be applied for loaded modules. This is the reason why after a restart engine wouldn't send **any** expression updates.
Should also fix #8941 |
Yes, the problem is going to be fixed, but only after clearing local caches. That's not fully ideal. Please change caches version ID as the serialized form for |
I gave up on adding a unit test. It looks like UUIDs aren't added to |
@@ -23,7 +23,7 @@ import scala.annotation.unused | |||
*/ | |||
|
|||
@SerialVersionUID( | |||
8160L // Use BindingsMap | |||
9057L // Use BindingsMap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are no longer using serialVersionUID
as we have our own Persistance
framework. Instructions to version caches are here.
Sorry for not stating that more clearly when requesting you to "Change caches version ID", but the last change to the documentation was done by you, so I expected you to remember the context.
As a result of not versioning the caches properly, I have to clean rm -rf ~/.local/shared/enso/caches/ir
to fix
Pull Request Description
Missing ID's in IR meant that instrumentation wouldn't be applied for loaded modules. This is the reason why after a restart engine wouldn't send any expression updates.
Closes #8689.
Important notes
After the change
Kazam_screencast_00038.webm
The video somehow doesn't show that all nodes are loaded after the restart, but once I moved the screen they are there. This appears to be a bug in the recording somehow.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.