-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New ... menu in the top bar with zoom controls #9073
New ... menu in the top bar with zoom controls #9073
Conversation
Fixed. The filter was there, but it was not applied due to some nesting of elements.
I updated the design. I left the label and the divider as they have been part of the proposed design (and are used in existing similar implementations. The label does help to make it clear what the controls are at a glance. Peek.2024-02-16.14-42.webm |
looks quite a bit cleaner now. still not too sure about a few things though:
|
I think we expect to have more positions in this menu soon, and then both the gap and label would make sense. If we don't make any such entries in a long time, then it will be easy to remove both the label and the gap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why do we need so many before
and after
elements, and what role they play.
it looks like the icons are implemented in pure CSS using pseudo-elements. i think they should probably be added to the icon spritesheet instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging it for now. But I think it would be better to use icons from our big svg - but that require a bit of figma work.
Pull Request Description
Closes #8614
0001-0093.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.