Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align XML_Document and XML_Element APIs more. #9233

Merged
merged 11 commits into from Mar 1, 2024
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 1, 2024

Pull Request Description

  • Added to_table extensions on some core types.
  • Added ICON to Any.to.
  • Added ICON to Column.info, Table.info, DB_Column.info and DB_Table.info.
  • Added defaults to Table.cross_tab and DB_Table.cross_tab.
  • Added name, get, at, inner_xml and outer_xml to XML_Document.
  • Added constants into left hand side of simple expressions.
  • Added widget to get and at on XML_Document and XML_Element. (Some bug in annotation code with Dmitry)
  • Altered get and at to not allow XPath and just get direct child/attribute values.
  • Added get_xpath to XML_Document.
  • Renamed get_elements_by_tag_name to get_descendants_by_tag_name and added new get_children_by_tag_name.
  • Added child_names and attribute_names to XML_Document and XML_Element.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Changelog.
Java format.
Comment on lines -23 to +24
* @throws TransformerException
* @throws ClassNotFoundException if the DOM implementation class cannot be found.
* @throws IllegalAccessException if the DOM implementation class cannot be accessed.
* @throws InstantiationException if the DOM implementation class cannot be instantiated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hard time understanding what is the difference between being able to access the class from instantiate it.

Do we need the distinction? Couldn't we throw the same kind of exception for these cases?

Is this exception even expected at all? Isn't it some kind of internal error if it occurs?

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 1, 2024
@mergify mergify bot merged commit 964fdfd into develop Mar 1, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/jd/xml-expand branch March 1, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants