Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a Data Link for Postgres #9269

Merged
merged 14 commits into from
Mar 6, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 4, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Comment on lines 148 to 150
if (Number.isFinite(newValue)) {
setValue(newValue)
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed because otherwise I could not have the field empty, so to type 5432 I had to type 05432 and only then delete the 0 afterwards, which was extremely annoying.

Now we can backspace on the 0 and type the correct port name. Empty field still has the red border as 'invalid input'.

@radeusgd
Copy link
Member Author

radeusgd commented Mar 4, 2024

image
image

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the fix for JSONSchemaInput.

@radeusgd
Copy link
Member Author

radeusgd commented Mar 5, 2024

Creating a datalink pointing directly to a DB_Table:
image
image

@radeusgd
Copy link
Member Author

radeusgd commented Mar 5, 2024

The linked table can be updated:
image

chrome_hKuYuN86om.mp4

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Mar 5, 2024
@mergify mergify bot merged commit e37862b into develop Mar 6, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/radeusgd/9124-postgres-datalink branch March 6, 2024 11:57
somebody1234 pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a datalink for Postgres
4 participants