Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed enso-types and a some unused dependencies. #9342

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Mar 8, 2024

Pull Request Description

Removed enso-types crate which had only one reference in unused part of the code. Removed some unused dependencies from Cargo.toml files.

Important Notes

CI has a similar hiccup as before. Please disregard this for now in the review.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow self-assigned this Mar 8, 2024
@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 8, 2024
@mwu-tow mwu-tow marked this pull request as ready for review March 8, 2024 19:09
Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Mar 11, 2024
@mergify mergify bot merged commit e7ca4aa into develop Mar 11, 2024
34 of 36 checks passed
@mergify mergify bot deleted the wip/mwu/post-gui1-cleanups branch March 11, 2024 17:44
@mwu-tow mwu-tow linked an issue Mar 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GUI1 codebase
3 participants