-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FQN and imports consistent #9367
Conversation
.../runtime-integration-tests/src/test/java/org/enso/compiler/ImportsAndFQNConsistencyTest.java
Outdated
Show resolved
Hide resolved
.../runtime-integration-tests/src/test/java/org/enso/compiler/ImportsAndFQNConsistencyTest.java
Outdated
Show resolved
Hide resolved
I believe the tests are now covering every type we have in the May I ask whether my patch fixes the failing tests? If so, I suggest to apply it, integrate and move on. The only objection I heard against my fix was: it doesn't solve the problem on the |
@JaroslavTulach Your patch fixes 9 out of 11 failing test cases. You are probably right about the IR generation - let's try to implement this in the |
Needed for the newly added tests to pass
…via FQN without import". This would introduce an incosistency. Let's not add this as a feature.
…sMap. This can happen, e.g., for synthetic modules.
Just keep the test for final BindingsMap Resolution metadata.
…-incosistent-import-and-fqn
…b.com:enso-org/enso into wip/akirathan/9329-incosistent-import-and-fqn
There is no use case for it yet.
This PR might be dropped in favor of #9539.
|
Yes, I think this PR doesn't need to be integrated. All related issues are already fixed.
|
Fixes #9329 and #6553
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.