Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing icon to Excel DataLink schema #9370

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

I forgot to do this in the previous PR #9346, so following up.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd
Copy link
Member Author

As discussed with @jdunkerley, to make it clearer that the user can hover over the text to see the explanation, I added an ℹ️ icon to the name, because the Default sheet name is not as clear, but we couldn't figure a much better one.

image

@radeusgd radeusgd self-assigned this Mar 11, 2024
@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Mar 11, 2024
@mergify mergify bot merged commit c401694 into develop Mar 11, 2024
31 of 37 checks passed
@mergify mergify bot deleted the wip/radeusgd/add-icon-to-schema branch March 11, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants