Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt graalVMVersionCheck does not fail during reload #9396

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Akirathan
Copy link
Member

Fixes #9395

Pull Request Description

Reload of sbt used to fail on "Not a valid command: graalVMVersionCheck" This PR fixes this issue.

Important Notes

Checked:

  • Manually running reload inside sbt shell
  • Temporarily setting a key in the current sbt shell with set javaOptions += "foo" and then reload.

Invoking sbt with incompatible java:

[info] welcome to sbt 1.9.7 (GraalVM Community Java 21)
[info] loading settings for project enso-build from plugins.sbt ...
[info] loading project definition from /home/pavel/dev/enso/project
[info] loading settings for project enso from build.sbt ...
[info] resolving key references (66170 settings) ...
[info] set current project to enso (in build file:/home/pavel/dev/enso/)
[error] Running on GraalVM version 21. Expected GraalVM version 21.0.2.
[warn] Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore? (default: r)

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 13, 2024
@Akirathan Akirathan self-assigned this Mar 13, 2024
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Mar 13, 2024
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Administrative approval. I have no clue of what is going on.

@mergify mergify bot merged commit 6e498e1 into develop Mar 13, 2024
38 of 39 checks passed
@mergify mergify bot deleted the wip/akirathan/9395-reloading-sbt-fails branch March 13, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sbt reload fails with "Not a valid command: graalVMVersionCheck"
2 participants