Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests on Mac #9401

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix e2e tests on Mac #9401

merged 1 commit into from
Mar 14, 2024

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Some e2e tests (about leaving nodes) were always failing on my machine because of the race condition in the tests. The issue was caused by edges positions lagging behind for a few frames when switching Enso functions, which caused incorrect handling of clicks in the test code.

Now we wait for edges being initialized and node sizes being updated.

Thanks to @farmaazon for helping with debugging.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the -gui label Mar 13, 2024
@vitvakatu vitvakatu self-assigned this Mar 13, 2024
@farmaazon farmaazon added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Mar 14, 2024
@mergify mergify bot merged commit 2ad6cdd into develop Mar 14, 2024
39 of 43 checks passed
@mergify mergify bot deleted the wip/vitvakatu/fix-e2e-tests branch March 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants