Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup GUI entrypoints and mocking #9403

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Mar 13, 2024

Pull Request Description

This is a set of split off changes made as a side effect while working on engine reconnection handling.

Cleaned up GUI e2e setup, unified as much of the entrypoint code as possible. Currently the only real difference between the real and testing entrypoint is mocking of all network calls and not loading through dashboard.

I've managed to completely get rid of MockApp, and remove tricky mocking of pinia stores.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Frizi Frizi added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Mar 13, 2024
app/gui2/src/util/net.ts Outdated Show resolved Hide resolved
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Mar 14, 2024
@mergify mergify bot merged commit 1b59744 into develop Mar 14, 2024
39 of 41 checks passed
@mergify mergify bot deleted the wip/frizi/entrypoint-cleanup branch March 14, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants