Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Table.replace to take mutiple target columns #9406

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Allow Table.replace to take mutiple target columns #9406

merged 10 commits into from
Mar 19, 2024

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Mar 13, 2024 •
edited
Loading

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis changed the title Make Table.replace take mutiple target columns Allow Table.replace to take mutiple target columns Mar 13, 2024
@GregoryTravis GregoryTravis linked an issue Mar 13, 2024 that may be closed by this pull request
Table.replace should take mutiple target columns #9400
Closed
@GregoryTravis GregoryTravis marked this pull request as ready for review March 13, 2024 18:32
radeusgd
radeusgd reviewed Mar 14, 2024
View reviewed changes
distribution/lib/Standard/Database/0.0.0-dev/src/DB_Table.enso Outdated
@@ -1554,16 +1554,16 @@ type DB_Table
## ALIAS find replace
GROUP Standard.Base.Text
ICON dataframe_map_column
Replaces values in `column` using `lookup_table` to specify a
mapping from old to new values.
Replaces values in the column or columns using `lookup_table` to specify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Replaces values in the column or columns using `lookup_table` to specify
Replaces values in the columns using `lookup_table` to specify

IMO that is simpler and says everything

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Mar 15, 2024
@GregoryTravis GregoryTravis added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Mar 15, 2024
@mergify mergify bot merged commit 53e2636 into develop Mar 19, 2024
39 of 40 checks passed
@mergify mergify bot deleted the wip/gmt/9400-replace-multiple branch March 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table.replace should take mutiple target columns
3 participants
@GregoryTravis @radeusgd @jdunkerley