-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ensogl-pack
#9407
Merged
Merged
Remove ensogl-pack
#9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somebody1234
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving ide-desktop
changes, which consist solely of files being removed, and minor changes to package.json
.
farmaazon
approved these changes
Mar 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR removes enso-pack (ensogl-pack) crate.
It still keeps the
enso-runner
JS package, as it is used for CLI argument parser and logger. The runner should be probably refactored (and possible removed altogether).Important Notes
I've temporarily extracted the
enso-runner
tolib/js
directory, as I wanted to avoid keeping pure JS library underlib/rust
. Attempts at integrating this withapp/ide-desktop
and family caused too much trouble for this PR. The expectation is that the package will be removed or moved elsewhere soon anyway.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.