Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ensogl-pack #9407

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Remove ensogl-pack #9407

merged 11 commits into from
Mar 18, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Mar 13, 2024

Pull Request Description

This PR removes enso-pack (ensogl-pack) crate.
It still keeps the enso-runner JS package, as it is used for CLI argument parser and logger. The runner should be probably refactored (and possible removed altogether).

Important Notes

I've temporarily extracted the enso-runner to lib/js directory, as I wanted to avoid keeping pure JS library under lib/rust. Attempts at integrating this with app/ide-desktop and family caused too much trouble for this PR. The expectation is that the package will be removed or moved elsewhere soon anyway.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 15, 2024
Copy link
Collaborator

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving ide-desktop changes, which consist solely of files being removed, and minor changes to package.json.

@mwu-tow mwu-tow self-assigned this Mar 18, 2024
@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Mar 18, 2024
@mwu-tow mwu-tow linked an issue Mar 18, 2024 that may be closed by this pull request
@mergify mergify bot merged commit de9f276 into develop Mar 18, 2024
41 checks passed
@mergify mergify bot deleted the wip/mwu/remove-enso-pack2 branch March 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove GUI1 codebase
3 participants