Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sqlite tests on mac #9408

Closed
wants to merge 3 commits into from
Closed

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Mar 13, 2024

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review March 13, 2024 21:11
Comment on lines 457 to 459
add_specs suite_builder
if Platform.os != OS.Mac_OS then
add_specs suite_builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this accomplishes what you want to accomplish. This will only skip SQLite tests when you run them as enso --run test/Table_Tests/src/Database/SQLite_Spec.enso and not if you run them as enso --run test/Table_Tests. I believe that you rather want:

diff --git a/test/Table_Tests/src/Database/Main.enso b/test/Table_Tests/src/Database/Main.enso
index fc8f6f56f..28dad6384 100644
--- a/test/Table_Tests/src/Database/Main.enso
+++ b/test/Table_Tests/src/Database/Main.enso
@@ -9,7 +9,8 @@ import project.Database.Redshift_Spec
 
 add_specs suite_builder =
     Codegen_Spec.add_specs suite_builder
-    SQLite_Spec.add_specs suite_builder
+    if Platform.os != OS.Mac_OS then
+        SQLite_Spec.add_specs suite_builder
     Postgres_Spec.add_specs suite_builder
     Redshift_Spec.add_specs suite_builder

By the way, you can mark a whole group as pending.

@GregoryTravis GregoryTravis added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 14, 2024
@GregoryTravis
Copy link
Contributor Author

If #9438 works, this won't be necessary.

@GregoryTravis
Copy link
Contributor Author

Looks like #9438 worked, so closing this.

@GregoryTravis GregoryTravis deleted the disable-macos-sqlite-tests branch May 8, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants