Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CSV file generation of bench_download script #9421

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Mar 14, 2024

Pull Request Description

One can now once more create CSV files from benchmark results with something like:

./bench_download.py -v -s stdlib --since 2024-01-01 --create-csv

The generated CSV is ready to be read by the Enso IDE.

Important Notes

  • Fix --create-csv functionality of the bench_download.py script.
  • Remove an outdated Enso project from tools/performance/engine_benchmarks/Engine_Benchs
    • This is now done by book clubs.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 14, 2024
@Akirathan Akirathan self-assigned this Mar 14, 2024
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Mar 14, 2024
@mergify mergify bot merged commit 0801fcb into develop Mar 14, 2024
39 of 41 checks passed
@mergify mergify bot deleted the wip/akirathan/fix-benchtool-csv branch March 14, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants