Store additional metainformation for defineKeybinds #9427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To display human-readable shortcuts in UI and use them in tests
Dashboard’s div was covering it
vitvakatu
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
Frizi,
farmaazon and
kazcw
as code owners
| @@ -217,7 +217,7 @@ | |||
| --side-panel-label-width: 8rem; | |||
| --side-panel-description-padding-y: 0.25rem; | |||
|
|
|||
| --extended-editor-menu-size: 2.5rem; | |||
| --extended-editor-menu-size: 48px; | |||
There was a problem hiding this comment.
for reference, 1rem = 16px. but i suppose this is more robust as the menu will always be a fixed pixel size.
There was a problem hiding this comment.
Yeah, I guess we want to use pixels here, as we know exact size of the button and exact pixel paddings around it.
somebody1234
approved these changes
Mar 15, 2024
farmaazon
approved these changes
Mar 15, 2024
Comment on lines
28
to
30
| // TODO[ao]: Skipping test, as they often fail in CI | ||
| // (for example https://github.com/enso-org/enso/actions/runs/8102076908/job/22163122663) | ||
| test.each` |
There was a problem hiding this comment.
Please remove the overlooked TODO.
| @@ -52,44 +59,44 @@ const areas: Record<string, Rect> = { | |||
| // TODO[ao]: Skipping test, as they often fail in CI | |||
| // (for example https://github.com/enso-org/enso/actions/runs/8102076908/job/22163122663) | |||
| test.each` | |||
app/gui2/src/util/shortcuts.ts
Outdated
| @@ -265,7 +299,7 @@ export const DefaultHandler = Symbol('default handler') | |||
| * @param bindings is an object defining actions and their key bindings. Each property name is an | |||
| * action name, and value is list of default key bindings. See "Keybinds should be parsed | |||
| * correctly" test for examples of valid strings. | |||
| * @returns an object with defined `handler` function. | |||
| * @returns an object with defined `handler` function and `bindings`, containing information about assigned bindings. | |||
There was a problem hiding this comment.
Over 100 characters. Alas, prettier does not handle docstrings
farmaazon
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #9411
Based on #9365
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.