Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expand_to_rows, expand_column support Rows, Tables, Column data types #9533

Merged
merged 5 commits into from Mar 26, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 25, 2024

Pull Request Description

Make expand_to_rows work for Table and Column
Make expand_column work for Column and Row

Makes solving the book club exercise easier

image

Important Notes

We decided expand_column did not make sense for Table as the resulting Table of Columns would rarely be what was wanted.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley changed the title Wip/adr/make expand columns work on tables Make expand_to_rows, expand_column support Rows, Tables, Column data types Mar 25, 2024
@AdRiley AdRiley force-pushed the wip/adr/make-expand-columns-work-on-tables branch from 35ae360 to 4e12764 Compare March 25, 2024 13:32
@AdRiley AdRiley marked this pull request as ready for review March 25, 2024 13:40
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

It's good to see that the Convertible_To_Rows and its sibling allow for such easy extensibility of this feature. It's nice to see some cool idioms for abstraction in Enso settling in.

I think we may want to add one test, although I assume it may not be strictly necessary because it is tested by other paths (I think JSON already tests this codepath well).

@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 25, 2024
@AdRiley AdRiley force-pushed the wip/adr/make-expand-columns-work-on-tables branch from 1c8a1d0 to 28ad13c Compare March 26, 2024 06:49
@AdRiley AdRiley force-pushed the wip/adr/make-expand-columns-work-on-tables branch from 28ad13c to 4493b51 Compare March 26, 2024 10:37
@mergify mergify bot merged commit 60fa83c into develop Mar 26, 2024
38 of 41 checks passed
@mergify mergify bot deleted the wip/adr/make-expand-columns-work-on-tables branch March 26, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants