Fix file browser on Linux and Windows #9538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
p-highest
farmaazon
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
Frizi,
vitvakatu and
kazcw
as code owners
somebody1234
approved these changes
Mar 25, 2024
vitvakatu
approved these changes
Mar 25, 2024
| @@ -381,15 +381,18 @@ class App { | |||
| }) | |||
| electron.ipcMain.handle( | |||
| ipc.Channel.openFileBrowser, | |||
| async (_event, kind: 'any' | 'directory' | 'file') => { | |||
| async (_event, kind: 'default' | 'directory' | 'file') => { | |||
| logger.log('Request for opening browser for ', kind) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9503
The
showFileBrowserdocumentation has a note, that Linux and Windows don't support enabling picking dir and file.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible../run ide build.