Avoiding trying to add a specific import if all already present. #9568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with dropdown and FQN clashes.
jdunkerley
requested review from
Frizi,
farmaazon,
vitvakatu and
kazcw
as code owners
jdunkerley
added
the
CI: No changelog needed
farmaazon
requested changes
Mar 28, 2024
app/gui2/src/stores/graph/index.ts
Outdated
Comment on lines
315
to
320
| // Let's check and see if the general import of the target module is already present. | ||
| const filteredNewImports = newImports.filter((newImport) => { | ||
| if (newImport.kind === 'Qualified') return true | ||
| return !existingImports.some((existingImport) => existingImport.from === newImport.from && existingImport.imported.kind === 'All') | ||
| }); | ||
|
|
There was a problem hiding this comment.
This should be done by working detectImportConflicts and filterOutRedundantImports below.
But the conflict resolution does not work properly; I would prefer removing the substitution from WidgetSelection, similar way as when creating node (
enso/app/gui2/src/stores/graph/index.ts
Line 292 in 62c3a0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with dropdown and FQN clashes.
Pull Request Description
While this doesn't fix the issues in the logic for conflict detection and the injected result, avoids the issue by checking if we have the import.
We should review the
resolveTagExpressionlogic separately.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.