Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block FQN substitution in drop downs #9569

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

While blocked FQN substitution when creating/editing node, the drop-downs still used it, and it does not work.

This amends that + added a reference to a task where we want to fix the original issue.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • [] Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon added p-highest Should be completed ASAP CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug -gui labels Mar 28, 2024
@farmaazon farmaazon self-assigned this Mar 28, 2024
Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple entry points throughout the whole codebase make it hard to catch all places. I think another one might be in checkbox widget, it also used conflict resolution for possible Boolean import.

@farmaazon
Copy link
Contributor Author

Multiple entry points throughout the whole codebase make it hard to catch all places. I think another one might be in checkbox widget, it also used conflict resolution for possible Boolean import.

Checkbox adds imports, but do not substitute with qualified names.

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Mar 28, 2024
@mergify mergify bot merged commit 207c7af into develop Mar 28, 2024
44 of 46 checks passed
@mergify mergify bot deleted the wip/farmaazon/block-fqn-substitution branch March 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants