Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table running functionality for Sum, Mean, Min, Max. #9577

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Mar 29, 2024

Pull Request Description

Complete Table.Running for Sum, Mean, Min, Max.

Variance, SD, Skew and Kurtosis will be a follow on PR as this one is already quite big.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley force-pushed the wip/adr/add-more-table-running-functionality branch 2 times, most recently from 09d438c to ae90090 Compare April 17, 2024 15:10
@AdRiley AdRiley changed the title Wip/adr/add more table running functionality Add table running functionality for Sum, Mean, Min, Max. Apr 18, 2024
@AdRiley AdRiley marked this pull request as ready for review April 18, 2024 10:58
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think looks good - like to think through how we can support different result value types for min/max.

@AdRiley AdRiley force-pushed the wip/adr/add-more-table-running-functionality branch from 6108188 to 0f3c33d Compare April 19, 2024 08:03
@AdRiley AdRiley merged commit 4a97bfa into develop Apr 23, 2024
36 checks passed
@AdRiley AdRiley deleted the wip/adr/add-more-table-running-functionality branch April 23, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants