Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump clap to v4 #9595

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Bump clap to v4 #9595

merged 4 commits into from
Apr 3, 2024

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Apr 2, 2024 •
edited

Pull Request Description

Now that the clap has fixed issue that blocked us, we can bump it across all our crates.

Fixes #5168.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow added x-chore Type: chore -build-script Category: build script labels Apr 2, 2024
@mwu-tow mwu-tow self-assigned this Apr 2, 2024
@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 2, 2024
@mwu-tow mwu-tow added the CI: Ready to merge This PR is eligible for automatic merge label Apr 3, 2024
@mergify mergify bot merged commit 96d17d2 into develop Apr 3, 2024
40 of 42 checks passed
@mergify mergify bot deleted the wip/mwu/bump-clap-2 branch April 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kazcw kazcw kazcw approved these changes

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@mwu-tow mwu-tow

Labels
-build-script Category: build script CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-chore Type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use non-literal expressions for name attribute Bump clap to version 4
3 participants
@mwu-tow @4e6 @kazcw