Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reported content-length in project manager shim. #9604

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Apr 2, 2024

Pull Request Description

Fixes dashboard errors that prevented the project list from loading when using node shim implementation of project listing commands, such as:

Could not list root folder.: Unterminated string in JSON at position 10021 (line 1 column 10022)

The issue was caused by a cut-off JSON response, due to incorrect calculation of encoded response byte length.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Frizi Frizi added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Apr 2, 2024
@somebody1234 somebody1234 changed the title Fix repoted content-length in project manager shim. Fix reported content-length in project manager shim. Apr 2, 2024
@somebody1234 somebody1234 added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Apr 2, 2024
@somebody1234
Copy link
Collaborator

QA passed ✔️

@mergify mergify bot merged commit ef79474 into develop Apr 3, 2024
46 checks passed
@mergify mergify bot deleted the wip/frizi/dashboard-project-list-shim branch April 3, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants