Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GraalVM 24.0.0 #9647

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Apr 8, 2024

Closes #9609

Pull Request Description

Update the GraalVM-related Maven packages from 23.1.2 to 24.0.0.

Important Notes

The language home search functionality in Truffle changed. It used to find the home for Enso from the class loader of EnsoLanguage:
https://github.com/oracle/graal/blob/graal-23.1.2/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L362

In 24.0.0, the language home is no longer found via class loader, but via system properties:
https://github.com/oracle/graal/blob/graal-24.0.0/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L353

I provided a "fix" for this by an explicit specification of the org.graalvm.language.enso.home system property in our launchers.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan added CI: No changelog needed Do not require a changelog entry for this PR. CI: Clean build required CI runners will be cleaned before and after this PR is built. labels Apr 8, 2024
@Akirathan Akirathan self-assigned this Apr 8, 2024
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the Dockerfile

Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove other usages of @Cached ignore. Otherwise fine. Thank you for such a smooth upgrade.

@Akirathan
Copy link
Member Author

Don't forget to update the Dockerfile

@4e6 Unlike to previous GraalVM updates, updating the Dockerfile is not necessary anymore. That Dockerfile will need updating once we update JDK version, and not the maven packages. Note that this PR only updates associated Maven packages, not JDK itself.

…alvm-24.0

# Conflicts:
#	tools/legal-review/engine/report-state
#	tools/legal-review/project-manager/report-state
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Apr 12, 2024
@mergify mergify bot merged commit 0d915d0 into develop Apr 12, 2024
36 checks passed
@mergify mergify bot deleted the wip/akirathan/9609-upgrade-graalvm-24.0 branch April 12, 2024 17:01
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
The change fixes the problem with suggestions loading by
1. Making sure that bundle is always the first on the search path for editions and engine
2. Passing language home to language server

Verified by building/running AppImage locally (previously would fail).

Closes #9728. Regressed in #9647.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to GraalVM 24.0 to resolve AssertionError: no root node & co.
5 participants