working hot reload for widget definitions #9657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixed a long-standing annoyance that widgets weren't fully hot-reloadable. Now when the widget definition (e.g.
score
function) is modified, it is hot-reloaded and new version immediately takes effect.widget-hmr.mp4
Important Notes
Because of how HMR API works, it needs to be passed from each widget module to the
widgetDefinition
function as an argument. When not provided, the definition will not be hot-reloadable (but the widget will still work as it used to).Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.