Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working hot reload for widget definitions #9657

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Apr 9, 2024

Pull Request Description

Fixed a long-standing annoyance that widgets weren't fully hot-reloadable. Now when the widget definition (e.g. score function) is modified, it is hot-reloaded and new version immediately takes effect.

widget-hmr.mp4

Important Notes

Because of how HMR API works, it needs to be passed from each widget module to the widgetDefinition function as an argument. When not provided, the definition will not be hot-reloadable (but the widget will still work as it used to).

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Frizi Frizi added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Apr 9, 2024
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Apr 11, 2024
@mergify mergify bot merged commit 922ac66 into develop Apr 11, 2024
36 of 37 checks passed
@mergify mergify bot deleted the wip/frizi/widget-hmr branch April 11, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants