Integer.to_decimal and Float.to_decimal
#9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd and
AdRiley
as code owners
radeusgd
reviewed
Apr 16, 2024
Comment on lines
+850
to
+851
| group_builder.specify "Float.to_decimal should attach a warning" <| | ||
| Problems.expect_warning Loss_Of_Numeric_Precision (12.3 . to_decimal) |
There was a problem hiding this comment.
I'm wondering if the explicit conversion should still have the warning? I guess if you do it explicitly maybe it's not needed?
There was a problem hiding this comment.
@jdunkerley has said that because people are often unfamiliar with the fact that Float is approximate (for example, not being able to represent 0.1 exactly), that we need these warnings always. But I think it's something we can discuss.
radeusgd
approved these changes
Apr 16, 2024
jdunkerley
approved these changes
Apr 16, 2024
GregoryTravis
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.