Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not use auto-scoping for atom types #9743

Merged

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Apr 18, 2024

Pull Request Description

close #9738

Do now use autoscope syntax for type definitions without constructors.

Important Notes

autoscope_nothing.mp4
autoscope_auto.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 18, 2024
@4e6 4e6 self-assigned this Apr 18, 2024
@4e6 4e6 requested a review from jdunkerley April 18, 2024 16:02
@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Apr 19, 2024
@mergify mergify bot merged commit f23455d into develop Apr 19, 2024
36 checks passed
@mergify mergify bot deleted the wip/db/9738-should-not-use-auto-scoping-for-atom-types branch April 19, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not use auto-scoping for atom types
2 participants