Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Table Viz handling of Numbers #9793

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Improve Table Viz handling of Numbers #9793

merged 3 commits into from
Apr 26, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Apr 25, 2024

Pull Request Description

  • Added support for NaN, Infinity and -Infinity in the Table viz.
  • Simplified the logic so all the formatting in a single place in the Table viz.
  • Sorted Number formatting for BigInt and < 10000.

image

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Sorted Number formatting for BigInt and < 10000.
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 25, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Apr 26, 2024
@mergify mergify bot merged commit c517930 into develop Apr 26, 2024
34 of 36 checks passed
@mergify mergify bot deleted the wip/jd/nan-tables branch April 26, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants