Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output ports: update style, improve interactivity #9842

Merged
merged 4 commits into from
May 6, 2024
Merged

Output ports: update style, improve interactivity #9842

merged 4 commits into from
May 6, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented May 2, 2024

Pull Request Description

output-ports.mov
  • Enlarge output port hover area; fix hover area extending above node
  • Show ports when selection is shown
  • Adjust port stroke-width and offset to match Figma
  • Change cursor when output port is hovered

Closes #9701

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw
Output port changes
90edb94 
- Enlarge output port hover area; fix hover area extending above node
- Show ports when selection is shown
- Adjust port stroke-width and offset to match Figma
- Change cursor when output port is hovered
@kazcw kazcw self-assigned this May 2, 2024
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label May 2, 2024
farmaazon
farmaazon approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the cursor changes over an output port, maybe it should change also over edges/connected ports?

@kazcw kazcw mentioned this pull request May 6, 2024
Open
@kazcw kazcw merged commit 36dcbf1 into develop May 6, 2024
34 checks passed
@kazcw kazcw deleted the wip/kw/output-ports branch May 6, 2024 16:36
@kazcw kazcw changed the title Output port changes Output ports: update style, improve interactivity May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Frizi approved these changes

@farmaazon farmaazon farmaazon approved these changes

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

Assignees

@kazcw kazcw

Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to click the output port to add a new component
3 participants
@kazcw @Frizi @farmaazon