Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make excel writer work for all types #9846

Merged
merged 6 commits into from
May 3, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented May 2, 2024

Pull Request Description

Adds a test file with all of our data types in and a test that makes sure we can round trip it to and from excel.
Changes the logic for reading date, times and datetimes from Excel to use the format string to identify the data type

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label May 2, 2024
@AdRiley AdRiley merged commit f647045 into develop May 3, 2024
36 checks passed
@AdRiley AdRiley deleted the wip/adr/make-excel-writer-work-for-all-types branch May 3, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants