Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the group colours for consistent colouring. #9893

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented May 8, 2024

Pull Request Description

Fix the group colour to a fixed set.

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label May 8, 2024
@jdunkerley jdunkerley changed the title wip/jd/group-colors Fix the group colours for consistent colouring. May 8, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label May 8, 2024
@mergify mergify bot merged commit ce360f9 into develop May 8, 2024
34 checks passed
@mergify mergify bot deleted the wip/jd/group-colors branch May 8, 2024 16:52
@radeusgd
Copy link
Member

radeusgd commented May 8, 2024

Btw. shouldn't a node containing a vector literal [1, 2, 3, 4] belong to the "Constants" group also? I.e. be colored the same way as Table.new?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants